Propagate child process exit code properly in edmPluginRefresh #44838

makortel · 2024-04-24T14:19:01Z

PR description:

#44821 (comment) reports the edmPluginRefresh returns a zero exit code even if a child process crashes. This PR propagates the non-zero exit code from the child process properly to the main process' exit() by using the WEXITSTATUS() macro as instructed in https://man7.org/linux/man-pages/man3/wait.3p.html.

Resolves cms-sw/framework-team#901

PR validation:

The reproducer in #44821 (comment) returns non-zero exit code.

cmsbuild · 2024-04-24T14:19:24Z

cms-bot internal usage

FWCore/PluginManager/bin/refresh.cc

makortel · 2024-04-24T14:22:15Z

@Dr15Jones @dan131riley Could you double-check?

cmsbuild · 2024-04-24T14:26:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44838/40084

This PR adds an extra 20KB to repository

cmsbuild · 2024-04-24T14:26:28Z

A new Pull Request was created by @makortel for master.

It involves the following packages:

FWCore/PluginManager (core)

@Dr15Jones, @smuzaffar, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-04-24T15:14:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44838/40087

This PR adds an extra 20KB to repository

cmsbuild · 2024-04-24T15:15:09Z

Pull request #44838 was updated. @makortel, @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

makortel · 2024-04-24T15:31:21Z

@cmsbuild, please test

cmsbuild · 2024-04-24T18:34:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-217df6/39073/summary.html
COMMIT: 24cdd45
CMSSW: CMSSW_14_1_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44838/39073/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.78 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 81 lines from the logs
Reco comparison results: 54 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3319852
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3319820
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

FWCore/PluginManager/bin/refresh.cc

Also when the child process was terminated by a signal.

cmsbuild · 2024-04-26T14:48:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44838/40109

This PR adds an extra 20KB to repository

cmsbuild · 2024-04-26T14:48:29Z

Pull request #44838 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

makortel · 2024-04-26T14:51:46Z

@cmsbuild, please test

cmsbuild · 2024-04-26T17:48:09Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-217df6/39123/summary.html
COMMIT: 6151d55
CMSSW: CMSSW_14_1_X_2024-04-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44838/39123/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.78 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 125 lines from the logs
Reco comparison results: 48 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3326929
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326903
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

makortel · 2024-04-26T18:03:09Z

Comparisons show the usual

makortel · 2024-04-26T18:07:06Z

+core

cmsbuild · 2024-04-26T18:07:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-04-29T01:21:25Z

+1

makortel changed the title ~~Propagate child process exit code properly in edmPluginRefresh~~ Propagate child process exit code properly in edmPluginRefresh Apr 24, 2024

makortel changed the title ~~Propagate child process exit code properly in edmPluginRefresh~~ Propagate child process exit code properly in edmPluginRefresh Apr 24, 2024

cmsbuild added this to the CMSSW_14_1_X milestone Apr 24, 2024

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Apr 24, 2024

makortel mentioned this pull request Apr 24, 2024

Multiple failures in NONLTO, CLANG and ASAN Unit Tests and RelVals due to PluginNotFound #44821

Open

makortel commented Apr 24, 2024

View reviewed changes

FWCore/PluginManager/bin/refresh.cc Outdated Show resolved Hide resolved

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 24, 2024

makortel force-pushed the edmPluginRefreshExitCode branch from 9229201 to c9dd2cb Compare April 24, 2024 15:03

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 24, 2024

makortel force-pushed the edmPluginRefreshExitCode branch from c9dd2cb to 24cdd45 Compare April 24, 2024 15:10

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 24, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 24, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 24, 2024

Dr15Jones reviewed Apr 26, 2024

View reviewed changes

FWCore/PluginManager/bin/refresh.cc Outdated Show resolved Hide resolved

Propagate child process exit code properly

6151d55

Also when the child process was terminated by a signal.

makortel force-pushed the edmPluginRefreshExitCode branch from 24cdd45 to 6151d55 Compare April 26, 2024 14:41

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Apr 26, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 26, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 26, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2024

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Apr 26, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 29, 2024

cmsbuild merged commit 93c1c50 into cms-sw:master Apr 29, 2024
11 checks passed

makortel deleted the edmPluginRefreshExitCode branch April 29, 2024 13:39

cmsbuild mentioned this pull request Apr 29, 2024

[cling] Make parts of the cling codebase similar to upstream clang-repl cms-sw/root#206

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propagate child process exit code properly in edmPluginRefresh #44838

Propagate child process exit code properly in edmPluginRefresh #44838

makortel commented Apr 24, 2024 •

edited

Loading

cmsbuild commented Apr 24, 2024 •

edited

Loading

makortel commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

makortel commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 26, 2024

cmsbuild commented Apr 26, 2024

makortel commented Apr 26, 2024

cmsbuild commented Apr 26, 2024

makortel commented Apr 26, 2024

makortel commented Apr 26, 2024

cmsbuild commented Apr 26, 2024

antoniovilela commented Apr 29, 2024

Propagate child process exit code properly in edmPluginRefresh #44838

Propagate child process exit code properly in edmPluginRefresh #44838

Conversation

makortel commented Apr 24, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Apr 24, 2024 • edited Loading

makortel commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

makortel commented Apr 24, 2024

cmsbuild commented Apr 24, 2024

Comparison Summary

cmsbuild commented Apr 26, 2024

cmsbuild commented Apr 26, 2024

makortel commented Apr 26, 2024

cmsbuild commented Apr 26, 2024

Comparison Summary

makortel commented Apr 26, 2024

makortel commented Apr 26, 2024

cmsbuild commented Apr 26, 2024

antoniovilela commented Apr 29, 2024

makortel commented Apr 24, 2024 •

edited

Loading

cmsbuild commented Apr 24, 2024 •

edited

Loading